close email connections when done #6496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2179 (and part of mozilla/sumo#1993)
Notes
django.core.mail.backends.smtp.EmailBackend
class -- which is whatdjango.core.mail.get_connection
returns -- is a Python context manager, so it'll automatically take care of opening and closing the connection when used in awith
statement.kitsune.sumo.email_utils.send_messages
function or thekitsune.tidings.events.Event.send_emails
method.